Service Report #017 In Review
Date: 2026-02-18
This report covers 2 bug fixes, 1 related improvement, and 1 feature request pending clarification. Issues include review comments blocked during co-review, WO/SO unable to sign JSA during co-review, workflow stepper display for completed tasks, and a request for partial JSA approval.
Feature Overview
| # | Feature | PR/Issue | Type | Status |
|---|---|---|---|---|
| 1 | JSA Review Comments Blocked During Co-Review | #440 | Bug Fix | ✅ Done |
| 2 | Workflow Stepper Shows Step 1 for Completed Tasks | — | Improvement | 🔍 In Review |
| 3 | WO/SO Cannot Sign JSA During Co-Review | #442 | Bug Fix | ✅ Done |
| 4 | JSA Partial Approval Request | #441 | Feature Request | ✅ Done |
1. JSA Review Comments Blocked During Co-Review
Issue: #440 Thai Name: เจ้าของงาน / จป : JSA คอมเม้นด้านล่างไม่ได้
Description: Work Owner and Safety Officer could not add review comments in the "Reviewer Comments" section during JSA co-review. The comment area was hidden because the form was in read-only mode for approval, which also blocked the comment feature.
Location: Tasks > JSA Preparation > Co-Review state > Open JSA document > Bottom of form
Behavior (After Fix)
| Role | Co-Review State | Preparation State | Completed |
|---|---|---|---|
| Work Owner | Can add/edit/delete comments | Can add/edit/delete comments | Read-only |
| Safety Officer | Can add/edit/delete comments | Cannot add comments | Read-only |
| Contractor | Read-only comments | Cannot see comments | Read-only |
What to Test
| # | Test Case | Status |
|---|---|---|
| 1 | Login as WO > Open JSA in co-review > Add review comment at bottom | ⌛ Pending |
| 2 | Login as SO > Open JSA in co-review > Add review comment at bottom | ⌛ Pending |
| 3 | Login as Contractor > Open JSA > Cannot add comments (read-only) | ⌛ Pending |
| 4 | Task completed > No one can add comments | ⌛ Pending |
2. Workflow Stepper Shows Step 1 for Completed Tasks
Thai Name: Stepper แสดงสถานะไม่ถูกต้องสำหรับงานที่เสร็จแล้ว
Description: When a JSA or Tool List task is approved and completed, the workflow stepper and workflow tab showed the task at step 1 instead of showing all steps as completed. This was because the backend sends the state name as "Approved" but the frontend only recognized "Completed".
Location: Tasks > JSA Preparation or Tool List Preparation > Completed task > Stepper tab and Workflow tab
Behavior (After Fix)
| Task State | Stepper Display | Workflow Tab |
|---|---|---|
| Approved / Completed | All steps shown as completed | Shows final "Completed" state |
| In Progress | Current step highlighted | Shows current state |
What to Test
| # | Test Case | Status |
|---|---|---|
| 1 | Open a completed JSA task > Stepper shows all steps completed | ⌛ Pending |
| 2 | Open a completed Tool List task > Stepper shows all steps completed | ⌛ Pending |
| 3 | Open a completed JSA task > Workflow tab shows "Completed" state | ⌛ Pending |
3. WO/SO Cannot Sign JSA During Co-Review
Issue: #442 Thai Name: เจ้าของงาน / จป : เซ็น JSA ไม่ได้
Description: During JSA co-review, Work Owner and Safety Officer could not sign their respective signature slots. Additionally, roles could sign any slot (not restricted to their own), and the signing dialog loaded the wrong user's saved signature when switching between accounts.
Location: Tasks > JSA Preparation > Co-Review state > Open JSA document > Signature section
Behavior (After Fix)
| Role | Can Sign | Required Before Approve |
|---|---|---|
| Contractor | "ผู้จัดทำ (ผู้รับเหมา)" only | Yes, before submitting JSA |
| Work Owner | "ผู้อนุมัติ (เจ้าของงาน)" only | Yes, before approving |
| Safety Officer | "ผู้อนุมัติ (เจ้าหน้าที่ความปลอดภัย)" only | Yes, before approving |
Three-Layer Approval Gating
| Layer | What Happens |
|---|---|
| Form validation | Submit/Approve buttons disabled until current role signs their slot |
| Document approval | Per-document approve button disabled until signature is complete |
| Workflow command | All JSA forms checked for current role's signatures before proceeding |
What to Test
| # | Test Case | Status |
|---|---|---|
| 1 | Login as Contractor > Open JSA > Can only click "ผู้จัดทำ" slot > Other slots show gray placeholder | ⌛ Pending |
| 2 | Login as WO in co-review > Can only click "ผู้อนุมัติ (เจ้าของงาน)" > Other slots show gray placeholder | ⌛ Pending |
| 3 | Login as SO in co-review > Can only click "ผู้อนุมัติ (จป.)" > Other slots show gray placeholder | ⌛ Pending |
| 4 | WO tries to approve without signing > Approve button is disabled | ⌛ Pending |
| 5 | SO tries to approve without signing > Approve button is disabled | ⌛ Pending |
| 6 | Contractor tries to submit without signing > Submit button is disabled + error dialog | ⌛ Pending |
| 7 | Login as SO > Sign > Logout > Login as WO > Sign > Shows WO's saved signature (not SO's) | ⌛ Pending |
| 8 | Multiple JSA forms > All must be signed before workflow approval | ⌛ Pending |
4. JSA Partial Approval Request
Issue: #441 Thai Name: เจ้าของงาน / จป : JSA ไม่จำเป็นต้องเลือกทุกรายการก็สามารถอนุมัติได้
Description: Feature request from tester — WO/SO should be able to approve the JSA workflow without approving every individual JSA document. Currently, all JSA documents must be approved (with signatures) before the workflow-level "Approve JSA" button is enabled.
Location: Tasks > JSA Preparation > Co-Review state > Approve JSA button
Status: Pending clarification from requester. A comment has been posted on the GitHub issue asking for the real-world scenario and expected behavior for unapproved items.
Concerns
| Aspect | Current Design | Requested Change |
|---|---|---|
| Per-document approval | Must approve all JSA documents | Can skip some documents |
| Workflow approval | Blocked until all documents approved | Allowed with partial approval |
| Signature requirement | WO/SO must sign each JSA form | Unclear |
Open Questions
- What happens to unapproved JSA items? (Deleted, returned, or skipped?)
- What is the real-world scenario requiring partial approval?
- How do signatures work for items that are not approved?
Summary
| # | Issue | Status |
|---|---|---|
| 1 | #440 — JSA review comments blocked during co-review | ✅ Done |
| 2 | Workflow stepper display for completed tasks | 🔍 In Review |
| 3 | #442 — WO/SO cannot sign JSA during co-review | ✅ Done |
| 4 | #441 — JSA partial approval request | ✅ Done |