Service Report #014 Done
Date: 2026-02-16
This report covers 2 bug fixes reported directly by testers via GitHub Issues. Both issues share the same root cause: JSA workflow command buttons were displayed to the wrong roles during the Co-Review state.
Feature Overview
| # | Feature | PR/Issue | Type | Status |
|---|---|---|---|---|
| 1 | WO/SO: JSA approve and return buttons disappeared | #411 | Bug Fix | ✅ Done |
| 2 | Contractor should not have JSA approve/return buttons | #412 | Bug Fix | ✅ Done |
1. WO/SO: JSA approve and return buttons disappeared
Issue: #411 Thai Name: WO/SO: ปุ่มอนุมัติ JSA และส่งกลับแก้ไขหายไป
Description: Work Owner and Safety Officer could no longer see the "อนุมัติ JSA" (Approve) and "ส่งกลับแก้ไข" (Return for Edit) buttons when reviewing a JSA task in Co-Review state.
Location: Tasks > จัดเตรียม JSA > เปิดงาน JSA ในสถานะตรวจสอบร่วม
Behavior
| Role | Before Fix | After Fix |
|---|---|---|
| Work Owner | No approve/return buttons | "อนุมัติ JSA" and "ส่งกลับแก้ไข" visible |
| Safety Officer | No approve/return buttons | "อนุมัติ JSA" and "ส่งกลับแก้ไข" visible |
What to Test
| # | Test Case | Status |
|---|---|---|
| 1 | Login as WO → Open JSA in review → "อนุมัติ JSA" button visible | ✅ Done |
| 2 | Login as WO → Open JSA in review → "ส่งกลับแก้ไข" button visible | ✅ Done |
| 3 | Login as SO → Open JSA in review → Same buttons visible | ✅ Done |
| 4 | Click approve/return → Buttons work correctly | ✅ Done |
2. Contractor should not have JSA approve/request change buttons
Issue: #412 Thai Name: ผู้รับเหมาไม่ควรมีปุ่มอนุมัติ/ส่งกลับแก้ไข JSA
Description: Contractor incorrectly saw "อนุมัติ JSA" and "ส่งกลับแก้ไข" buttons on JSA tasks. These are reviewer-only actions for Work Owner and Safety Officer.
Location: ผู้รับเหมา > Tasks > จัดเตรียม JSA
Behavior
| Role | Before Fix | After Fix |
|---|---|---|
| Contractor (during preparation) | Wrong buttons visible | Only "ส่ง JSA" (Submit) and "ยกเลิก" (Cancel) |
| Contractor (during review) | "อนุมัติ JSA" and "ส่งกลับแก้ไข" visible | No command buttons (task belongs to WO/SO) |
What to Test
| # | Test Case | Status |
|---|---|---|
| 1 | Login as Contractor → Open JSA in review state → No approve/return buttons | ✅ Done |
| 2 | Login as Contractor → Open JSA in preparation → Only Submit and Cancel visible | ✅ Done |
| 3 | Login as Contractor → Submit JSA works correctly | ✅ Done |
Summary
| # | Issue | Status |
|---|---|---|
| 1 | #411 — WO/SO buttons missing | ✅ Done |
| 2 | #412 — Contractor has wrong buttons | ✅ Done |
PR: #414 Version: Preview34